linux-kernel - Re: [PATCH v1 tty] 8250: microchip: Add 4 Mbps support in PCI1XXXX UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 28 Jan 2024 17:28:54 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Rengarajan S <rengarajan.s@...rochip.com>
Cc: kumaravel.thiagarajan@...rochip.com,
	tharunkumar.pasumarthi@...rochip.com, gregkh@...uxfoundation.org,
	jirislaby@...nel.org, ilpo.jarvinen@...ux.intel.com,
	f.fainelli@...il.com, john.ogness@...utronix.de, tony@...mide.com,
	tglx@...utronix.de, jiaqing.zhao@...ux.intel.com,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v1 tty] 8250: microchip: Add 4 Mbps support in PCI1XXXX
 UART

On Sun, Jan 28, 2024 at 05:27:24PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 25, 2024 at 03:36:19PM +0530, Rengarajan S wrote:

..

> > +#define UART_BAUD_4MBPS				4000000
> 
> (4 * MEGA) ? (will need to include units.h, if not yet)

..and use proper namespace for the definition.
UART_ one is not owned by this driver.

-- 
With Best Regards,
Andy Shevchenko