linux-kernel - Re: [PATCH] qcom: smem: remove hwspinlock from item get routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 28 Jan 2024 11:45:52 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: konrad.dybcio@...aro.org,
	Tao Zhang <quic_taozhan@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	kernel@...cinc.com
Subject: Re: [PATCH] qcom: smem: remove hwspinlock from item get routine


On Tue, 02 Jan 2024 07:55:12 +0530, Tao Zhang wrote:
> During an SSR(Sub-System Restart) process, the remoteproc driver will
> try to read the crash reason from SMEM. The qcom_smem_get() backing such
> operations does however take the hwspinlock (tcsr mutex), which might be
> held by the dying remoteproc.
> 
> The associated timeout on the hwspin_lock_timeout_irqsave() would take
> care of the system not hanging forever, but the get operation will fail,
> unnecessarily delaying the process for the 'HWSPINLOCK_TIMEOUT' duration
> (currently is '1s'), and finally resulting in failure to get crash
> information from SMEM.
> 
> [...]

Applied, thanks!

[1/1] qcom: smem: remove hwspinlock from item get routine
      commit: 27825593c972abac86b9a4453a8c8c9a2c1ec60f

Best regards,
-- 
Bjorn Andersson <andersson@...nel.org>