linux-kernel - Re: [PATCH 1/1] dt-bindings: riscv: cpus: reg matches hart ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 28 Jan 2024 19:23:39 +0100
From: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
To: Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: riscv: cpus: reg matches hart ID

On 1/28/24 19:20, Conor Dooley wrote:
> On Sun, Jan 28, 2024 at 07:06:21PM +0100, Heinrich Schuchardt wrote:
>> Add a description to the CPU reg property to clarify that
>> the reg property must match the hart ID.
> 
> That is the expected usage alright. Did you come across something where
> it was not being used in that way?

No. I was simply missing it in the documentation.

There is a page 
https://www.kernel.org/doc/Documentation/devicetree/bindings/riscv/cpus.txt 
but that seems not to be generated from the kernel tree.

Best regards

Heinrich

> 
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> Cheers,
> Conor.
> 
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
>> ---
>>   Documentation/devicetree/bindings/riscv/cpus.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Documentation/devicetree/bindings/riscv/cpus.yaml
>> index f392e367d673..fa9da59d9316 100644
>> --- a/Documentation/devicetree/bindings/riscv/cpus.yaml
>> +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml
>> @@ -74,6 +74,10 @@ properties:
>>         - riscv,sv57
>>         - riscv,none
>>   
>> +  reg:
>> +    description:
>> +      The hart ID of this CPU node.
>> +
>>     riscv,cbom-block-size:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>       description:
>> -- 
>> 2.43.0
>>