[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240129165952.0dec633e@donnerap.manchester.arm.com>
Date: Mon, 29 Jan 2024 16:59:52 +0000
From: Andre Przywara <andre.przywara@....com>
To: Chen-Yu Tsai <wens@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland
<samuel@...lland.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
<broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
<tiwai@...e.com>, Vinod Koul <vkoul@...nel.org>, Chen-Yu Tsai
<wens@...e.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-sound@...r.kernel.org, dmaengine@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/7] dt-bindings: dma: allwinner,sun50i-a64-dma: Add
compatible for H616
On Sun, 28 Jan 2024 00:32:44 +0800
Chen-Yu Tsai <wens@...nel.org> wrote:
Hi,
> From: Chen-Yu Tsai <wens@...e.org>
>
> The DMA controllers found on the H616 and H618 are the same as the one
> found on the A100. The only difference is the DMA endpoint (DRQ) layout.
>
> Since the number of channels and endpoints are described with additional
> generic properties, just add a new H616-specific compatible string and
> fallback to the A100 one.
>
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
Looks good, A100 is the right fallback string. dt-binding_check passed for
me.
Reviewed-by: Andre Przywara <andre.przywara@....com>
Cheers,
Andre
> ---
> Changes since v1:
> - Switch to "contains" for if-properties statement
> - Fall back to A100 instead of H6
>
> .../bindings/dma/allwinner,sun50i-a64-dma.yaml | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> index ec2d7a789ffe..0f2501f72cca 100644
> --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> @@ -28,6 +28,9 @@ properties:
> - items:
> - const: allwinner,sun8i-r40-dma
> - const: allwinner,sun50i-a64-dma
> + - items:
> + - const: allwinner,sun50i-h616-dma
> + - const: allwinner,sun50i-a100-dma
>
> reg:
> maxItems: 1
> @@ -59,10 +62,11 @@ required:
> if:
> properties:
> compatible:
> - enum:
> - - allwinner,sun20i-d1-dma
> - - allwinner,sun50i-a100-dma
> - - allwinner,sun50i-h6-dma
> + contains:
> + enum:
> + - allwinner,sun20i-d1-dma
> + - allwinner,sun50i-a100-dma
> + - allwinner,sun50i-h6-dma
>
> then:
> properties:
Powered by blists - more mailing lists