linux-kernel - Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240129193344.GFZbf9mEIxZg7ZEb8f@fat_crate.local>
Date: Mon, 29 Jan 2024 20:33:44 +0100
From: Borislav Petkov <bp@...en8.de>
To: Liam Merwick <liam.merwick@...cle.com>
Cc: Michael Roth <michael.roth@....com>, "x86@...nel.org" <x86@...nel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"jroedel@...e.de" <jroedel@...e.de>,
	"thomas.lendacky@....com" <thomas.lendacky@....com>,
	"hpa@...or.com" <hpa@...or.com>,
	"ardb@...nel.org" <ardb@...nel.org>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>,
	"seanjc@...gle.com" <seanjc@...gle.com>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>,
	"jmattson@...gle.com" <jmattson@...gle.com>,
	"luto@...nel.org" <luto@...nel.org>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"slp@...hat.com" <slp@...hat.com>,
	"pgonda@...gle.com" <pgonda@...gle.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
	"rientjes@...gle.com" <rientjes@...gle.com>,
	"tobin@....com" <tobin@....com>, "vbabka@...e.cz" <vbabka@...e.cz>,
	"kirill@...temov.name" <kirill@...temov.name>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"sathyanarayanan.kuppuswamy@...ux.intel.com" <sathyanarayanan.kuppuswamy@...ux.intel.com>,
	"alpergun@...gle.com" <alpergun@...gle.com>,
	"jarkko@...nel.org" <jarkko@...nel.org>,
	"ashish.kalra@....com" <ashish.kalra@....com>,
	"nikunj.dadhania@....com" <nikunj.dadhania@....com>,
	"pankaj.gupta@....com" <pankaj.gupta@....com>,
	Brijesh Singh <brijesh.singh@....com>
Subject: Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and
 PSMASH instruction

On Mon, Jan 29, 2024 at 08:28:20PM +0100, Borislav Petkov wrote:
> On Mon, Jan 29, 2024 at 06:00:36PM +0000, Liam Merwick wrote:
> > asid is typically a u32 (or at least unsigned) - is it better to avoid 
> > potential conversion issues with an 'int'?
> 
> struct rmp_state.asid is already u32 but yeah, lemme fix that.

Btw,

static int sev_get_asid(struct kvm *kvm)
{
        struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info;

        return sev->asid;
}

whereas

struct kvm_sev_info {
	...
        unsigned int asid;      /* ASID used for this guest */

so that function needs fixing too.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette