linux-kernel - Re: regression/bisected commit 773688a6cb24b0b3c2ba40354d883348a2befa38 make my system completely unusable under high load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 Jan 2024 00:14:38 +0100
From: Andrey Konovalov <andreyknvl@...il.com>
To: Mikhail Gavrilov <mikhail.v.gavrilov@...il.com>
Cc: Marco Elver <elver@...gle.com>, glider@...gle.com, dvyukov@...gle.com, 
	eugenis@...gle.com, Oscar Salvador <osalvador@...e.de>, Vlastimil Babka <vbabka@...e.cz>, 
	Andrew Morton <akpm@...ux-foundation.org>, 
	Linux List Kernel Mailing <linux-kernel@...r.kernel.org>, 
	Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: regression/bisected commit 773688a6cb24b0b3c2ba40354d883348a2befa38
 make my system completely unusable under high load

On Mon, Jan 29, 2024 at 11:25 PM Mikhail Gavrilov
<mikhail.v.gavrilov@...il.com> wrote:
>
> On Fri, Jan 19, 2024 at 10:54 PM Mikhail Gavrilov
> <mikhail.v.gavrilov@...il.com> wrote:
> >
> I continued to search regressions in 6.8 kernel.
> And found another one.
>
> cc478e0b6bdffd20561e1a07941a65f6c8962cab is the first bad commit
> commit cc478e0b6bdffd20561e1a07941a65f6c8962cab
> Author: Andrey Konovalov <andreyknvl@...il.com>
> Date:   Tue Jan 9 23:12:34 2024 +0100
>
>     kasan: avoid resetting aux_lock
>
> Here I spotted a dropped FPS in the game "Shadow of the Tomb Raider".
> For measuring performance I used an internal benchmark.
> Before commit cc478e0b6bdffd20561e1a07941a65f6c8962cab was 111FPS on
> commit aaa2c9a97c22af5bf011f6dd8e0538219b45af88 [1].
> On commit cc478e0b6bdffd20561e1a07941a65f6c8962cab I has only 63FPS [2]
> And unfortunately the stackdepot patchset which I applied on top of
> 6.8-rc2 didn't restore initial performance [3].
>
> [1] https://i.postimg.cc/tgvwPTkz/c11-aaa2c9a97c22af5bf011f6dd8e0538219b45af88.png
> [2] https://i.postimg.cc/pX8vHDCM/c10-cc478e0b6bdffd20561e1a07941a65f6c8962cab.png
> [3] https://i.postimg.cc/hvWCb7dV/6-8-0-0-rc2-with-stackdepot.png

Hi Mikhail,

Please try to apply these two patches on top:
https://lore.kernel.org/linux-mm/20240129100708.39460-1-elver@google.com/

They effectively revert the change you mentioned.

Thank you for testing!