lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 29 Jan 2024 23:46:20 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Chancel Liu <chancel.liu@....com>
Cc: lgirdwood@...il.com,
	broonie@...nel.org,
	perex@...ex.cz,
	tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: soc-core.c: Prefer to return dai->driver->name in snd_soc_dai_name_get()


Hi Chancel

Thank you for the patch

> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 516350533e73..09467c693627 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -300,12 +300,12 @@ static int snd_soc_is_matching_dai(const struct snd_soc_dai_link_component *dlc,
>  const char *snd_soc_dai_name_get(struct snd_soc_dai *dai)
>  {
>  	/* see snd_soc_is_matching_dai() */
> -	if (dai->name)
> -		return dai->name;
> -
>  	if (dai->driver->name)
>  		return dai->driver->name;
>  
> +	if (dai->name)
> +		return dai->name;
> +
>  	if (dai->component->name)
>  		return dai->component->name;
>  
> -- 

As above comment indicated, snd_soc_dai_name_get() and
snd_soc_is_matching_dai() are paired.
If you want to update snd_soc_dai_name_get(), updating
snd_soc_is_matching_dai() also is good idea.


Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ