linux-kernel - Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874jewy9rd.fsf@vajain21.in.ibm.com>
Date: Mon, 29 Jan 2024 11:13:50 +0530
From: Vaibhav Jain <vaibhav@...ux.ibm.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Michael Ellerman
 <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe
 Leroy <christophe.leroy@...roup.eu>,
        "Aneesh Kumar K.V"
 <aneesh.kumar@...nel.org>,
        "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
        Kautuk Consul <kconsul@...ux.vnet.ibm.com>,
        Amit Machhiwal
 <amachhiw@...ux.vnet.ibm.com>,
        Jordan Niethe <jniethe5@...il.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Gautam Menghani
 <gautam@...ux.ibm.com>, linuxppc-dev@...ts.ozlabs.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling
 path in gs_msg_ops_kvmhv_nestedv2_config_fill_info()




Christophe JAILLET <christophe.jaillet@...adoo.fr> writes:

<snip>
>  	if (kvmppc_gsm_includes(gsm, KVMPPC_GSID_RUN_OUTPUT)) {
> -		kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT,
> -					 cfg->vcpu_run_output_cfg);
> +		rc = kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT,
> +					      cfg->vcpu_run_output_cfg);
>  		if (rc < 0)
>  			return rc;
>  	}
> -- 
Thanks for catching this and the change looks good to me.

Reviewed-by: Vaibhav Jain <vaibhav@...ux.ibm.com>

-- 
Cheers
~ Vaibhav