[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b3643a21-d0a8-4c4c-85de-852055a2d08b@quicinc.com>
Date: Mon, 29 Jan 2024 11:57:54 +0530
From: "Maulik Shah (mkshah)" <quic_mkshah@...cinc.com>
To: Andrew Halaney <ahalaney@...hat.com>
CC: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio
<konrad.dybcio@...aro.org>,
<linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<quic_eberman@...cinc.com>, <quic_collinsd@...cinc.com>,
<quic_lsrao@...cinc.com>
Subject: Re: [PATCH v2] soc: qcom: rpmh-rsc: Enhance check for VREG in-flight
request
Hi,
On 1/19/2024 9:17 PM, Andrew Halaney wrote:
>> Signed-off-by: Maulik Shah <quic_mkshah@...cinc.com>
>> Signed-off-by: Elliot Berman <quic_eberman@...cinc.com>
>
> Just noticed I commented on v1 when v2 was already out, sorry. Copy
> pasting this just to keep it on the latest thread:
>
> Two minor things:
>
> 1. Does this deserve a Fixes: tag?
> 2. The Signed-off-by chain here confuses me, you sent the patch
> so your SOB should be last, but then that makes me believe Elliot
> was the author which I don't think is reflected here (no From:
> line). Please read [0] for a bit more details
>
> [0] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
Yes, this looks good to have patch, will include fixes: tag and will
fix SOB in v3.
Thanks,
Maulik
Powered by blists - more mailing lists