linux-kernel - RE: [PATCH v12 2/5] iommu/vt-d: don't issue ATS Invalidation request when device is disconnected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Jan 2024 08:53:48 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Ethan Zhao <haifeng.zhao@...ux.intel.com>, "baolu.lu@...ux.intel.com"
	<baolu.lu@...ux.intel.com>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"robin.murphy@....com" <robin.murphy@....com>, "jgg@...pe.ca" <jgg@...pe.ca>
CC: "dwmw2@...radead.org" <dwmw2@...radead.org>, "will@...nel.org"
	<will@...nel.org>, "lukas@...ner.de" <lukas@...ner.de>, "Liu, Yi L"
	<yi.l.liu@...el.com>, "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, Haorong Ye
	<yehaorong@...edance.com>
Subject: RE: [PATCH v12 2/5] iommu/vt-d: don't issue ATS Invalidation request
 when device is disconnected

> From: Ethan Zhao <haifeng.zhao@...ux.intel.com>
> Sent: Monday, January 29, 2024 11:49 AM
> 
[snip]
> Fixes: 6f7db75e1c46 ("iommu/vt-d: Add second level page table interface")
> Tested-by: Haorong Ye <yehaorong@...edance.com>
> Signed-off-by: Ethan Zhao <haifeng.zhao@...ux.intel.com>
> ---
>  drivers/iommu/intel/pasid.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c
> index 3239cefa4c33..953592125e4a 100644
> --- a/drivers/iommu/intel/pasid.c
> +++ b/drivers/iommu/intel/pasid.c
> @@ -214,6 +214,9 @@ devtlb_invalidation_with_pasid(struct intel_iommu
> *iommu,
>  	if (!info || !info->ats_enabled)
>  		return;
> 
> +	if (pci_dev_is_disconnected(to_pci_dev(dev)))
> +		return;
> +

the long commit msg doesn't tell the fact that this is not a full fix.
surprise removal could happen after that check so there could still
be chance seeing timeout.