linux-kernel - Re: [PATCH v14 2/4] Input: add core support for Goodix Berlin Touchscreen IC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cef1e9ec-1aae-400f-bb30-05d43c6211f4@linaro.org>
Date: Mon, 29 Jan 2024 10:02:33 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Bastien Nocera <hadess@...ess.net>,
 Hans de Goede <hdegoede@...hat.com>, Henrik Rydberg <rydberg@...math.org>,
 Jeff LaBundy <jeff@...undy.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v14 2/4] Input: add core support for Goodix Berlin
 Touchscreen IC

On 12/01/2024 16:08, Neil Armstrong wrote:
> Hi Dmitry,
> 
> On 11/01/2024 08:20, Dmitry Torokhov wrote:
>> Hi Neil,
>>
>> On Thu, Dec 21, 2023 at 04:21:20PM +0100, Neil Armstrong wrote:
>>> Add initial support for the new Goodix "Berlin" touchscreen ICs.
>>
>> Thank you very much for explaining how reading of additional contacts
>> and checksum works, it makes sense now.
>>
>> I was a bit unhappy about number of times we copy/move the data over;
>> could you please try the patch below to see if the device still works
>> with it?
> 
> Sure, I'll test it and report you.

Ok it still works fine!

Sending v15 with those changes and rebased on latest linux-next.

Thanks,
Neil

> 
>>
>> I also shortened some #defines and defines some additional structures.
>> Also as far as I can see not everything needs to be packed as the data
>> is naturally aligned on the word boundaries.
> 
> Great, thank!
> 
> Neil
> 
>>
>> Thanks!
>>
>