[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8b5dfed3-f881-4f0a-be81-d7fcf3be0deb@arm.com>
Date: Mon, 29 Jan 2024 14:43:08 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Alexandru Elisei <alexandru.elisei@....com>, catalin.marinas@....com,
will@...nel.org, oliver.upton@...ux.dev, maz@...nel.org,
james.morse@....com, suzuki.poulose@....com, yuzenghui@...wei.com,
arnd@...db.de, akpm@...ux-foundation.org, mingo@...hat.com,
peterz@...radead.org, juri.lelli@...hat.com, vincent.guittot@...aro.org,
dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
mhiramat@...nel.org, rppt@...nel.org, hughd@...gle.com
Cc: pcc@...gle.com, steven.price@....com, vincenzo.frascino@....com,
david@...hat.com, eugenis@...gle.com, kcc@...gle.com, hyesoo.yu@...sung.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
kvmarm@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
linux-arch@...r.kernel.org, linux-mm@...ck.org,
linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH RFC v3 05/35] mm: cma: Don't append newline when
generating CMA area name
On 1/25/24 22:12, Alexandru Elisei wrote:
> cma->name is displayed in several CMA messages. When the name is generated
> by the CMA code, don't append a newline to avoid breaking the text across
> two lines.
An example of such mis-formatted CMA output from dmesg could be added
here in the commit message to demonstrate the problem better.
>
> Signed-off-by: Alexandru Elisei <alexandru.elisei@....com>
> ---
Regardless, LGTM.
Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>
>
> Changes since rfc v2:
>
> * New patch. This is a fix, and can be merged independently of the other
> patches.
Right, need not be part of this series. Hence please send it separately to
the MM list.
>
> mm/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 7c09c47e530b..f49c95f8ee37 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -204,7 +204,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size,
> if (name)
> snprintf(cma->name, CMA_MAX_NAME, name);
> else
> - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count);
> + snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count);
>
> cma->base_pfn = PFN_DOWN(base);
> cma->count = size >> PAGE_SHIFT;
Powered by blists - more mailing lists