linux-kernel - Re: [PATCH] RAS/AMD/ATL: Add MI300 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 29 Jan 2024 10:25:41 +0100
From: Borislav Petkov <bp@...en8.de>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: tony.luck@...el.com, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, avadhut.naik@....com,
	john.allen@....com, Muralidhara M K <muralidhara.mk@....com>
Subject: Re: [PATCH] RAS/AMD/ATL: Add MI300 support

On Sun, Jan 28, 2024 at 09:59:50AM -0600, Yazen Ghannam wrote:
> From: Muralidhara M K <muralidhara.mk@....com>
> 
> AMD MI300 systems include on-die HBM3 memory and a unique topology. And
> they fall under Data Fabric version 4.5 in overall design.
> 
> Generally, topology information (IDs, etc.) is gathered from Data Fabric
> registers. However, the unique topology for MI300 means that some
> topology information is fixed in hardware and follows arbitrary
> mappings. Furthermore, not all hardware instances are software-visible,
> so register accesses must be adjusted.
> 
> Recognize and add helper functions for the new MI300 interleave modes.
> Add lookup tables for fixed values where appropriate. Adjust how Die and
> Node IDs are found and used.
> 
> Also, fix some register bitmasks that were mislabeled.
> 
> Signed-off-by: Muralidhara M K <muralidhara.mk@....com>
> Co-developed-by: Yazen Ghannam <yazen.ghannam@....com>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>

Applied, thanks.

> ---
> Notes:
> This patch is based on patches 2, 4, and 5 from the following set.
> https://lore.kernel.org/r/20231129073521.2127403-1-muralimk@amd.com
> 
> Patch 3 from above set is still needed for complete MI300 address
> translation support. This will be the first to follow.
> 
> Patch 6 from above set is needed for expanding page retirement on MI300
> systems. This will be the second to follow.
> 
> Patch 1 from above set adds MI200 support to ATL. This will be deferred
> until after priority MI300 updates.

Yap, agreed.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette