linux-kernel - Re: [PATCH 4/4] firmware: ti_sci: Use devm_register_restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202401291053.Bc9G6QTc-lkp@intel.com>
Date: Mon, 29 Jan 2024 10:16:20 +0800
From: kernel test robot <lkp@...el.com>
To: Andrew Davis <afd@...com>, Mark Rutland <mark.rutland@....com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Sebastian Reichel <sre@...nel.org>,
	Karol Gugala <kgugala@...micro.com>,
	Mateusz Holenko <mholenko@...micro.com>,
	Gabriel Somlo <gsomlo@...il.com>, Joel Stanley <joel@....id.au>,
	Mark Brown <broonie@...nel.org>, Orson Zhai <orsonzhai@...il.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@...il.com>, Lee Jones <lee@...nel.org>,
	Dmitry Osipenko <dmitry.osipenko@...labora.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-spi@...r.kernel.org, Andrew Davis <afd@...com>
Subject: Re: [PATCH 4/4] firmware: ti_sci: Use devm_register_restart_handler()

Hi Andrew,

kernel test robot noticed the following build warnings:

[auto build test WARNING on lee-leds/for-leds-next]
[also build test WARNING on linus/master v6.8-rc1 next-20240125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrew-Davis/kernel-reboot-Deprecate-register_restart_handler/20240124-005424
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link:    https://lore.kernel.org/r/20240123164443.394642-5-afd%40ti.com
patch subject: [PATCH 4/4] firmware: ti_sci: Use devm_register_restart_handler()
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240129/202401291053.Bc9G6QTc-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240129/202401291053.Bc9G6QTc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401291053.Bc9G6QTc-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/firmware/ti_sci.c:120: warning: Excess struct member 'nb' description in 'ti_sci_info'


vim +120 drivers/firmware/ti_sci.c

aa276781a64a5f Nishanth Menon 2016-10-18   85  
aa276781a64a5f Nishanth Menon 2016-10-18   86  /**
aa276781a64a5f Nishanth Menon 2016-10-18   87   * struct ti_sci_info - Structure representing a TI SCI instance
aa276781a64a5f Nishanth Menon 2016-10-18   88   * @dev:	Device pointer
aa276781a64a5f Nishanth Menon 2016-10-18   89   * @desc:	SoC description for this instance
912cffb4ed8612 Nishanth Menon 2016-10-18   90   * @nb:	Reboot Notifier block
aa276781a64a5f Nishanth Menon 2016-10-18   91   * @d:		Debugfs file entry
aa276781a64a5f Nishanth Menon 2016-10-18   92   * @debug_region: Memory region where the debug message are available
aa276781a64a5f Nishanth Menon 2016-10-18   93   * @debug_region_size: Debug region size
aa276781a64a5f Nishanth Menon 2016-10-18   94   * @debug_buffer: Buffer allocated to copy debug messages.
aa276781a64a5f Nishanth Menon 2016-10-18   95   * @handle:	Instance of TI SCI handle to send to clients.
aa276781a64a5f Nishanth Menon 2016-10-18   96   * @cl:		Mailbox Client
aa276781a64a5f Nishanth Menon 2016-10-18   97   * @chan_tx:	Transmit mailbox channel
aa276781a64a5f Nishanth Menon 2016-10-18   98   * @chan_rx:	Receive mailbox channel
aa276781a64a5f Nishanth Menon 2016-10-18   99   * @minfo:	Message info
aa276781a64a5f Nishanth Menon 2016-10-18  100   * @node:	list head
e69a35531589a2 Nishanth Menon 2018-08-28  101   * @host_id:	Host ID
aa276781a64a5f Nishanth Menon 2016-10-18  102   * @users:	Number of users of this instance
aa276781a64a5f Nishanth Menon 2016-10-18  103   */
aa276781a64a5f Nishanth Menon 2016-10-18  104  struct ti_sci_info {
aa276781a64a5f Nishanth Menon 2016-10-18  105  	struct device *dev;
aa276781a64a5f Nishanth Menon 2016-10-18  106  	const struct ti_sci_desc *desc;
aa276781a64a5f Nishanth Menon 2016-10-18  107  	struct dentry *d;
aa276781a64a5f Nishanth Menon 2016-10-18  108  	void __iomem *debug_region;
aa276781a64a5f Nishanth Menon 2016-10-18  109  	char *debug_buffer;
aa276781a64a5f Nishanth Menon 2016-10-18  110  	size_t debug_region_size;
aa276781a64a5f Nishanth Menon 2016-10-18  111  	struct ti_sci_handle handle;
aa276781a64a5f Nishanth Menon 2016-10-18  112  	struct mbox_client cl;
aa276781a64a5f Nishanth Menon 2016-10-18  113  	struct mbox_chan *chan_tx;
aa276781a64a5f Nishanth Menon 2016-10-18  114  	struct mbox_chan *chan_rx;
aa276781a64a5f Nishanth Menon 2016-10-18  115  	struct ti_sci_xfers_info minfo;
aa276781a64a5f Nishanth Menon 2016-10-18  116  	struct list_head node;
e69a35531589a2 Nishanth Menon 2018-08-28  117  	u8 host_id;
aa276781a64a5f Nishanth Menon 2016-10-18  118  	/* protected by ti_sci_list_mutex */
aa276781a64a5f Nishanth Menon 2016-10-18  119  	int users;
aa276781a64a5f Nishanth Menon 2016-10-18 @120  };
aa276781a64a5f Nishanth Menon 2016-10-18  121  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki