linux-kernel - Re: [PATCH net] nfc: nci: free rx_data_reassembly skb on NCI device cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <170653022632.12593.11211557853168091033.git-patchwork-notify@kernel.org>
Date: Mon, 29 Jan 2024 12:10:26 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Fedor Pchelkin <pchelkin@...ras.ru>
Cc: krzysztof.kozlowski@...aro.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, jeremy@...ine.org, horms@...nel.org,
 leitao@...ian.org, ilane@...com, linville@...driver.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, khoroshilov@...ras.ru,
 lvc-project@...uxtesting.org, stable@...r.kernel.org,
 syzbot+6b7c68d9c21e4ee4251b@...kaller.appspotmail.com
Subject: Re: [PATCH net] nfc: nci: free rx_data_reassembly skb on NCI device
 cleanup

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Thu, 25 Jan 2024 12:53:09 +0300 you wrote:
> rx_data_reassembly skb is stored during NCI data exchange for processing
> fragmented packets. It is dropped only when the last fragment is processed
> or when an NTF packet with NCI_OP_RF_DEACTIVATE_NTF opcode is received.
> However, the NCI device may be deallocated before that which leads to skb
> leak.
> 
> As by design the rx_data_reassembly skb is bound to the NCI device and
> nothing prevents the device to be freed before the skb is processed in
> some way and cleaned, free it on the NCI device cleanup.
> 
> [...]

Here is the summary with links:
  - [net] nfc: nci: free rx_data_reassembly skb on NCI device cleanup
    https://git.kernel.org/netdev/net/c/bfb007aebe6b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html