linux-kernel - Re: [PATCH v4 1/3] irqchip/loongson-eiointc: Typo fix in function eiointc_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Jan 2024 20:23:18 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Bibo Mao <maobibo@...ngson.cn>
Cc: Jiaxun Yang <jiaxun.yang@...goat.com>, Thomas Gleixner <tglx@...utronix.de>, 
	linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Sergey Shtylyov <s.shtylyov@....ru>, lvjianmin@...ngson.cn, 
	Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH v4 1/3] irqchip/loongson-eiointc: Typo fix in function eiointc_domain_alloc

Hi, Bibo,

We usually use eiointc_domain_alloc() rather than eiointc_domain_alloc
to describe a function, but it is not a big issue. If you will update
a new version you can modify this.

Huacai

On Thu, Jan 25, 2024 at 7:36 PM Bibo Mao <maobibo@...ngson.cn> wrote:
>
> There is small typo in function eiointc_domain_alloc, and there is no
> definition about struct eiointc, instead it should be struct eiointc_priv.
> It is strange that there is no warning with gcc compiler. This patch
> fixes the typo issue.
>
> Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
> Acked-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---
>  drivers/irqchip/irq-loongson-eiointc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c
> index 1623cd779175..b3736bdd4b9f 100644
> --- a/drivers/irqchip/irq-loongson-eiointc.c
> +++ b/drivers/irqchip/irq-loongson-eiointc.c
> @@ -241,7 +241,7 @@ static int eiointc_domain_alloc(struct irq_domain *domain, unsigned int virq,
>         int ret;
>         unsigned int i, type;
>         unsigned long hwirq = 0;
> -       struct eiointc *priv = domain->host_data;
> +       struct eiointc_priv *priv = domain->host_data;
>
>         ret = irq_domain_translate_onecell(domain, arg, &hwirq, &type);
>         if (ret)
> --
> 2.39.3
>