[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <mafs034ugtgqk.fsf@kernel.org>
Date: Mon, 29 Jan 2024 14:24:19 +0100
From: Pratyush Yadav <pratyush@...nel.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: pratyush@...nel.org, michael@...le.cc, miquel.raynal@...tlin.com,
richard@....at, jaimeliao@...c.com.tw, linux-mtd@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mtd: spi-nor: sysfs: hide the flash name if not set
On Fri, Dec 15 2023, Tudor Ambarus wrote:
> From: JaimeLiao <jaimeliao@...c.com.tw>
>
> The flash name is not reliable as we saw flash ID collisions.
> Hide the flash name if not set.
>
> Signed-off-by: JaimeLiao <jaimeliao@...c.com.tw>
> [ta: update commit subject and description]
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> ---
> Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor | 3 +++
> drivers/mtd/spi-nor/sysfs.c | 2 ++
> 2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor b/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor
> index c800621eff95..6d7be97bf7d1 100644
> --- a/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor
> +++ b/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor
> @@ -25,6 +25,9 @@ KernelVersion: 5.14
> Contact: linux-mtd@...ts.infradead.org
> Description: (RO) Part name of the SPI NOR flash.
>
> + The attribute is not present if the jedec_id founded in
> + ID table but flash name didn't include in it.
Nitpick: strange sentence construction makes it a bit confusing.
Perhaps:
The attribute is not present if the JEDEC ID table for the flash
does not include its name.
> +
>
> What: /sys/bus/spi/devices/.../spi-nor/sfdp
> Date: April 2021
> diff --git a/drivers/mtd/spi-nor/sysfs.c b/drivers/mtd/spi-nor/sysfs.c
> index 2dfdc555a69f..96064e4babf0 100644
> --- a/drivers/mtd/spi-nor/sysfs.c
> +++ b/drivers/mtd/spi-nor/sysfs.c
> @@ -78,6 +78,8 @@ static umode_t spi_nor_sysfs_is_visible(struct kobject *kobj,
>
> if (attr == &dev_attr_manufacturer.attr && !nor->manufacturer)
> return 0;
> + if (attr == &dev_attr_partname.attr && !nor->info->name)
> + return 0;
Do you want to show the name for the "spi-nor-generic" flash? If not
then perhaps drop its name as well?
> if (attr == &dev_attr_jedec_id.attr && !nor->info->id && !nor->id)
> return 0;
--
Regards,
Pratyush Yadav
Powered by blists - more mailing lists