linux-kernel - Re: [PATCH 1/2] riscv: dts: sophgo: cv18xx: Add spi devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240129030115.GB1097489@ofsar>
Date: Mon, 29 Jan 2024 03:01:15 +0000
From: Yixun Lan <dlan@...too.org>
To: Inochi Amaoto <inochiama@...look.com>
Cc: Chao Wei <chao.wei@...hgo.com>, Chen Wang <unicorn_wang@...look.com>,
	Conor Dooley <conor@...nel.org>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Jisheng Zhang <jszhang@...nel.org>,
	Liu Gui <kenneth.liu@...hgo.com>,
	Jingbao Qiu <qiujingbao.dlmu@...il.com>,
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] riscv: dts: sophgo: cv18xx: Add spi devices

Hi Inochi Amaoto

On 10:26 Mon 29 Jan     , Inochi Amaoto wrote:
> Add spi devices for the CV180x, CV181x and SG200x soc.
> 
> Signed-off-by: Inochi Amaoto <inochiama@...look.com>
> ---
>  arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 44 ++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> index 7c88cbe8e91d..e66f9e9feb48 100644
> --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> @@ -176,6 +176,50 @@ uart3: serial@...0000 {
>  			status = "disabled";
>  		};
> 
> +		spi0: spi@...0000 {
> +			compatible = "snps,dw-apb-ssi";
> +			reg = <0x04180000 0x10000>;
> +			interrupts = <54 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk CLK_SPI>, <&clk CLK_APB_SPI0>;
> +			clock-names = "ssi_clk", "pclk";
.
> +			#address-cells = <1>;
> +			#size-cells = <0>;
I'd suggest moving those two above 'interrupts' property

there is an ongoing discussion here..
https://lore.kernel.org/all/20231203174622.18402-1-krzysztof.kozlowski@linaro.org/

> +			status = "disabled";
> +		};
> +
> +		spi1: spi@...0000 {
> +			compatible = "snps,dw-apb-ssi";
> +			reg = <0x04190000 0x10000>;
> +			interrupts = <55 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk CLK_SPI>, <&clk CLK_APB_SPI1>;
> +			clock-names = "ssi_clk", "pclk";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			status = "disabled";
> +		};
> +
> +		spi2: spi@...0000 {
> +			compatible = "snps,dw-apb-ssi";
> +			reg = <0x041a0000 0x10000>;
> +			interrupts = <56 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk CLK_SPI>, <&clk CLK_APB_SPI2>;
> +			clock-names = "ssi_clk", "pclk";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			status = "disabled";
> +		};
> +
> +		spi3: spi@...0000 {
> +			compatible = "snps,dw-apb-ssi";
> +			reg = <0x041b0000 0x10000>;
> +			interrupts = <57 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk CLK_SPI>, <&clk CLK_APB_SPI3>;
> +			clock-names = "ssi_clk", "pclk";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			status = "disabled";
> +		};
> +
>  		uart4: serial@...0000 {
>  			compatible = "snps,dw-apb-uart";
>  			reg = <0x041c0000 0x100>;
> --
> 2.43.0

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55