[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2541ed5c-2afe-4cd4-861c-53aad2c355ea@web.de>
Date: Mon, 29 Jan 2024 15:42:31 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: linux-arm-msm@...r.kernel.org, kernel-janitors@...r.kernel.org,
Arnd Bergmann <arnd@...db.de>, Amol Maheshwari <amahesh@....qualcomm.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Cong Liu <liucong2@...inos.cn>,
Kunwu Chan <chentao@...inos.cn>
Subject: [PATCH v2] misc: fastrpc: Use memdup_user() rather than duplicating
its implementation
From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 29 Jan 2024 15:33:41 +0100
* Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.
Generated by: scripts/coccinelle/api/memdup_user.cocci
* Adjust a data type conversion for a function call parameter.
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
v2:
A data type conversion should still be applied for one function call parameter.
drivers/misc/fastrpc.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 1c6c62a7f7f5..3b18c339d091 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1260,17 +1260,12 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl,
goto err;
}
- name = kzalloc(init.namelen, GFP_KERNEL);
- if (!name) {
- err = -ENOMEM;
+ name = memdup_user(u64_to_user_ptr(init.name), init.namelen);
+ if (IS_ERR(name) {
+ err = PTR_ERR(name);
goto err;
}
- if (copy_from_user(name, (void __user *)(uintptr_t)init.name, init.namelen)) {
- err = -EFAULT;
- goto err_name;
- }
-
if (!fl->cctx->remote_heap) {
err = fastrpc_remote_heap_alloc(fl, fl->sctx->dev, init.memlen,
&fl->cctx->remote_heap);
--
2.43.0
Powered by blists - more mailing lists