linux-kernel - Re: [PATCH] usb: uhci-grlib: Explicitly include linux/platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024012905-sulphuric-collie-7ede@gregkh>
Date: Mon, 29 Jan 2024 06:59:18 -0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Andreas Larsson <andreas@...sler.com>
Cc: Alan Stern <stern@...land.harvard.edu>, linux-usb@...r.kernel.org,
	Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
	software@...sler.com
Subject: Re: [PATCH] usb: uhci-grlib: Explicitly include
 linux/platform_device.h

On Mon, Jan 29, 2024 at 06:58:50AM -0800, Greg Kroah-Hartman wrote:
> On Mon, Jan 29, 2024 at 08:41:50AM +0100, Andreas Larsson wrote:
> > On 2024-01-28 01:31, Greg Kroah-Hartman wrote:
> > > On Mon, Jan 22, 2024 at 09:22:25AM +0100, Andreas Larsson wrote:
> > >> This fixes relying upon linux/of_platform.h to include
> > >> linux/platform_device.h, which it no longer does, thereby fixing
> > >> compilation problems like:
> > >>
> > >> In file included from drivers/usb/host/uhci-hcd.c:850:
> > >> drivers/usb/host/uhci-grlib.c: In function 'uhci_hcd_grlib_probe':
> > >> drivers/usb/host/uhci-grlib.c:92:29: error: invalid use of undefined type 'struct platform_device'
> > >>    92 |  struct device_node *dn = op->dev.of_node;
> > >>       |                             ^~
> > >>
> > >> Fixes: 0d18bcdebb2f ("of: Stop circularly including of_device.h and of_platform.h")
> > > 
> > > I don't see this commit id in Linus's tree, where is it?
> > 
> > Ah, sorry, it went into Linus's tree with a different commit ID. I
> > should have referred to ef175b29a242.
> 
> Please fix up and resend.

Ah you did, just hadn't read all of my email yet, sorry for the noise...