linux-kernel - Re: [PATCH 0/3] arm64: Add support for airoha en7581 Soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d905f921-927d-4978-acef-6b2822bf9b64@kernel.org>
Date: Mon, 29 Jan 2024 16:20:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Daniel Danzberger <dd@...edd.com>, catalin.marinas@....com,
 will@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] arm64: Add support for airoha en7581 Soc

On 01/10/2023 14:24, Daniel Danzberger wrote:
> Hi,
> 
> I would like to add linux support for this new platform.
> These 3 patches only add very basic support for the platform and
> it's evaluation board.
> 
> The changes contain just some additions to the existing Kconfig and 2 dts files.

You did not get any responses... because of few issues. First, you did
not Cc SoC maintainers, literally no one, so this will be totally
ignored. Second, you missed some lists explicitly asked by
get_maintainers.pl, so this should not be merged anyway. Also, I don't
see checkpatch run on it... so standard disclaimers:

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts_getmaintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, use mainline), work on fork of kernel (don't, use
mainline) or you ignore some maintainers (really don't). Just use b4 and
everything should be fine, although remember about `b4 prep
--auto-to-cc` if you added new patches to the patchset.

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Also, please provide proper maintainers entry. If you do not intend to
be maintainer of it, Cc some of SoC maintainers to get it merged through
them.

Best regards,
Krzysztof