[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdUKXwxAKgtmgMxj+y-8GBWBLWC=ROP31uStTnfLDx6OLQ@mail.gmail.com>
Date: Tue, 30 Jan 2024 14:26:12 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: daniel.lezcano@...aro.org, miquel.raynal@...tlin.com, rafael@...nel.org,
rui.zhang@...el.com, lukasz.luba@....com, support.opensource@...semi.com,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-imx@....com, andersson@...nel.org,
konrad.dybcio@...aro.org, amitk@...nel.org, thara.gopinath@...il.com,
niklas.soderlund@...natech.se, srinivas.pandruvada@...ux.intel.com,
baolin.wang@...ux.alibaba.com, u.kleine-koenig@...gutronix.de,
hayashi.kunihiko@...ionext.com, d-gole@...com, linus.walleij@...aro.org,
DLG-Adam.Ward.opensource@...renesas.com, error27@...il.com, heiko@...ech.de,
hdegoede@...hat.com, jernej.skrabec@...il.com, f.fainelli@...il.com,
bchihi@...libre.com, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
linux-renesas-soc@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH v1 02/18] thermal: Add new structures and thermal_zone_device_register()
Hi Angelo,
On Tue, Jan 30, 2024 at 12:13 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
> In preparation for extending the thermal zone devices to actually
> have a name and disambiguate thermal zone types/names, and to do
> a reorganization in thermal_zone_device, add some new Thermal Zone
> structures:
>
> Introduce new thermal_governor_params, thermal_zone_platform_params
> and thermal_zone_device_params structures which are meant to hold
> the parameters for thermal zone registration and, in the future, to
> stop having a catch-all thermal_zone_device structure.
>
> While at it, also add a new thermal_zone_device_register() function
> which uses the new structure(s) for registration;
> the now old functions thermal_tripless_zone_device_register() and
> thermal_zone_device_register_with_trips() are now advertised as
> being deprecated and changed to instead act as wrappers around the
> new thermal_zone_device_register().
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Thanks for your patch!
> ---
> drivers/thermal/gov_power_allocator.c | 38 +++----
> drivers/thermal/qcom/tsens.c | 4 +-
> drivers/thermal/thermal_core.c | 146 ++++++++++++++++++--------
> drivers/thermal/thermal_helpers.c | 8 +-
> drivers/thermal/thermal_sysfs.c | 16 +--
> include/linux/thermal.h | 73 +++++++++++--
> 6 files changed, 202 insertions(+), 83 deletions(-)
This also needs an update to the documentation, which still refers to
the old function removed in commit edd220b33f479cf9 ("thermal: core:
Drop thermal_zone_device_register()") in v6.6.:
Documentation/driver-api/thermal/power_allocator.rst:`thermal_zone_device_register()`
Documentation/driver-api/thermal/power_allocator.rst:`thermal_zone_device_register()`
(i.e., platform code), then weights
Documentation/driver-api/thermal/sysfs-api.rst:
*thermal_zone_device_register(char *type,
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists