linux-kernel - Re: [PATCH v1 06/18] thermal/drivers/rcar: Migrate to thermal_zone_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240130150852.GB2544372@ragnatech.se>
Date: Tue, 30 Jan 2024 16:08:52 +0100
From: Niklas Söderlund <niklas.soderlund@...natech.se>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: daniel.lezcano@...aro.org, miquel.raynal@...tlin.com, rafael@...nel.org,
	rui.zhang@...el.com, lukasz.luba@....com,
	support.opensource@...semi.com, shawnguo@...nel.org,
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
	linux-imx@....com, andersson@...nel.org, konrad.dybcio@...aro.org,
	amitk@...nel.org, thara.gopinath@...il.com,
	srinivas.pandruvada@...ux.intel.com, baolin.wang@...ux.alibaba.com,
	u.kleine-koenig@...gutronix.de, hayashi.kunihiko@...ionext.com,
	d-gole@...com, linus.walleij@...aro.org,
	DLG-Adam.Ward.opensource@...renesas.com, error27@...il.com,
	heiko@...ech.de, hdegoede@...hat.com, jernej.skrabec@...il.com,
	f.fainelli@...il.com, bchihi@...libre.com, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-arm-msm@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	kernel@...labora.com
Subject: Re: [PATCH v1 06/18] thermal/drivers/rcar: Migrate to
 thermal_zone_device_register()

Hi AngeloGioacchino,

Thanks for your work.

On 2024-01-30 12:12:38 +0100, AngeloGioacchino Del Regno wrote:
> The thermal API has a new thermal_zone_device_register() function which
> is deprecating the older thermal_zone_device_register_with_trips() and
> thermal_tripless_zone_device_register().
> 
> Migrate to the new thermal zone device registration function.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

> ---
>  drivers/thermal/rcar_thermal.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index feb848d595fa..7bf9c1611a00 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -488,10 +488,17 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>  						dev, i, priv,
>  						&rcar_thermal_zone_ops);
>  		} else {
> -			priv->zone = thermal_zone_device_register_with_trips(
> -				"rcar_thermal", trips, ARRAY_SIZE(trips), 0, priv,
> -						&rcar_thermal_zone_ops, NULL, 0,
> -						idle);
> +			struct thermal_zone_device_params tzdp = {
> +				.tzp = {
> +					.type = "rcar_thermal",
> +					.ops = &rcar_thermal_zone_ops,
> +					.devdata = priv,
> +					.trips = trips,
> +					.num_trips = ARRAY_SIZE(trips),
> +					.polling_delay = idle,
> +				}
> +			};
> +			priv->zone = thermal_zone_device_register(&tzdp);
>  
>  			ret = thermal_zone_device_enable(priv->zone);
>  			if (ret) {
> -- 
> 2.43.0
> 

-- 
Kind Regards,
Niklas Söderlund