[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b7e2e9d1-5e3e-44b2-a4b7-327d334b776d@moroto.mountain>
Date: Tue, 30 Jan 2024 18:49:02 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-fpga@...r.kernel.org, kernel-janitors@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Luwei Kang <luwei.kang@...el.com>, Moritz Fischer <mdf@...nel.org>,
Tom Rix <trix@...hat.com>, Wu Hao <hao.wu@...el.com>,
Xu Yilun <yilun.xu@...el.com>, LKML <linux-kernel@...r.kernel.org>,
Kunwu Chan <chentao@...inos.cn>
Subject: Re: [PATCH] fpga: dfl: fme: Return directly after a failed
devm_kasprintf() call in fme_perf_pmu_register()
On Sat, Jan 27, 2024 at 03:55:19PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 27 Jan 2024 15:43:42 +0100
>
> The result from a call of the function “devm_kasprintf” was passed to
> a subsequent function call without checking for a null pointer before
> (according to a memory allocation failure).
> This issue was detected by using the Coccinelle software.
>
> Thus return directly after a failed devm_kasprintf() call.
>
> Fixes: 724142f8c42a7 ("fpga: dfl: fme: add performance reporting support")
This basically doesn't affect runtime because perf_pmu_register() checks
for NULL so no need for a Fixes tag.
regards,
dan carpenter
Powered by blists - more mailing lists