linux-kernel - Re: [EXTERNAL] Re: [PATCH v2 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc867ca4-e579-47f5-8490-ebefbc3c2875@linaro.org>
Date: Tue, 30 Jan 2024 17:18:14 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Ding, Shenghao" <shenghao-ding@...com>
Cc: "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "robh+dt@...nel.org" <robh+dt@...nel.org>,
 "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
 "Lu, Kevin" <kevin-lu@...com>, "Xu, Baojun" <baojun.xu@...com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "P O, Vijeth" <v-po@...com>, "lgirdwood@...il.com" <lgirdwood@...il.com>,
 "perex@...ex.cz" <perex@...ex.cz>,
 "pierre-louis.bossart@...ux.intel.com"
 <pierre-louis.bossart@...ux.intel.com>,
 "13916275206@....com" <13916275206@....com>,
 "Chawla, Mohit" <mohit.chawla@...com>,
 "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
 "soyer@....hu" <soyer@....hu>, "Huang, Jonathan" <jkhuang3@...com>,
 "tiwai@...e.de" <tiwai@...e.de>, "Djuandi, Peter" <pdjuandi@...com>,
 "McPherson, Jeff" <j-mcpherson@...com>,
 "Navada Kanyana, Mukund" <navada@...com>, Mark Brown <broonie@...nel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v2 4/4] ASoc: dt-bindings: PCM6240: Add
 initial DT binding

On 29/01/2024 05:43, Ding, Shenghao wrote:
>>
>> On Fri, Jan 26, 2024 at 09:27:47AM +0100, Krzysztof Kozlowski wrote:
>>> On 26/01/2024 04:58, Shenghao Ding wrote:
>>
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            enum:
>>>> +              - ti,pcm1690
>>>> +    then:
>>>> +      properties:
>>>> +        reg:
>>>> +          items:
>>>> +            minimum: 0x4c
>>>> +            maximum: 0x4f
>>
>>> Nothing improved.
>>
>> Shenghao explained what what this is doing - I'm not sure what the actual
>> problem is here?  It's an actual restriction on the values that are valid.
> 
> Hi, Krzysztof. May I have the privilege to petition on behalf of my customers? They 
> want to keep these if branches and the i2c address in yaml file. As you know, most 
> of my customers used to make mistakes and confuse with the i2c address. Listing 
> them here can help them to get the information easily.

To which cases this exception will apply? Your patches, all TI?

Bindings are not supposed to be so detailed to create DTS out if it,
because it makes them more difficult to maintain. Such amount of
if:then: makes it trickier, for no real gain.

Best regards,
Krzysztof