linux-kernel - Re: fpga: dfl: fme: Return directly after a failed devm_kasprintf() call in fme_perf_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e760bd1b-30bf-489f-b745-128d05397feb@web.de>
Date: Tue, 30 Jan 2024 18:09:14 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Dan Carpenter <dan.carpenter@...aro.org>, linux-fpga@...r.kernel.org,
 kernel-janitors@...r.kernel.org,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Moritz Fischer <mdf@...nel.org>, Tom Rix <trix@...hat.com>,
 Wu Hao <hao.wu@...el.com>, Xu Yilun <yilun.xu@...el.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Kunwu Chan <chentao@...inos.cn>
Subject: Re: fpga: dfl: fme: Return directly after a failed devm_kasprintf()
 call in fme_perf_pmu_register()

>> Thus return directly after a failed devm_kasprintf() call.
>>
>> Fixes: 724142f8c42a7 ("fpga: dfl: fme: add performance reporting support")
>
> This basically doesn't affect runtime because perf_pmu_register() checks
> for NULL so no need for a Fixes tag.

I suggest to clarify this view a bit more also according to statements
like the following.

1. https://elixir.bootlin.com/linux/v6.8-rc2/source/kernel/events/core.c#L11532
   perf_pmu_register:
   …
	pmu->name = name;
   …

2. https://elixir.bootlin.com/linux/v6.8-rc2/source/kernel/events/core.c#L11472
   pmu_dev_alloc:
   …
	ret = dev_set_name(pmu->dev, "%s", pmu->name);
   …


Regards,
Markus