linux-kernel - Re: [PATCH AUTOSEL 5.10 3/8] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zblkn9lNZXQUQQuc@sashalap>
Date: Tue, 30 Jan 2024 16:05:35 -0500
From: Sasha Levin <sashal@...nel.org>
To: Pavel Machek <pavel@...x.de>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Avadhut Naik <Avadhut.Naik@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tony Luck <tony.luck@...el.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
	bleung@...omium.org, tzungbi@...nel.org,
	chrome-platform@...ts.linux.dev
Subject: Re: [PATCH AUTOSEL 5.10 3/8] platform/chrome: cros_ec_debugfs: Fix
 permissions for panicinfo

On Tue, Jan 16, 2024 at 09:45:12PM +0100, Pavel Machek wrote:
>Hi!
>
>> From: Avadhut Naik <Avadhut.Naik@....com>
>>
>> [ Upstream commit 0706526ec7704dcd046239078ac175d11a88a95e ]
>>
>> The debugfs_create_blob() function has been used to create read-only binary
>> blobs in debugfs. The function filters out permissions, other than S_IRUSR,
>> S_IRGRP and S_IROTH, provided while creating the blobs.
>>
>> The very behavior though is being changed through previous patch in the
>> series (fs: debugfs: Add write functionality to debugfs blobs) which makes
>> the binary blobs writable by owners. Thus, all permissions provided while
>> creating the blobs, except S_IRUSR,S_IWUSR, S_IRGRP, S_IROTH, will be
>> filtered by debugfs_create_blob().
>
>This needs previous patch to make sense (according to changelog), and
>we don't have that. Please drop.

Dropped, thanks!

-- 
Thanks,
Sasha