linux-kernel - Re: [PATCH -next v4 1/3] x86/mce: remove redundant fixup type EX_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240130210918.GFZbllfs4jUcd_QHL2@fat_crate.local>
Date: Tue, 30 Jan 2024 22:09:18 +0100
From: Borislav Petkov <bp@...en8.de>
To: Tong Tiangen <tongtiangen@...wei.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	wangkefeng.wang@...wei.com,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>, Tony Luck <tony.luck@...el.com>,
	Andy Lutomirski <luto@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Naoya Horiguchi <naoya.horiguchi@....com>,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	linux-mm@...ck.org, Guohanjun <guohanjun@...wei.com>
Subject: Re: [PATCH -next v4 1/3] x86/mce: remove redundant fixup type
 EX_TYPE_COPY

On Thu, Jan 11, 2024 at 09:55:46PM +0800, Tong Tiangen wrote:
> In commit 034ff37d3407 ("x86: rewrite '__copy_user_nocache' function"),
> rewrited __copy_user_nocache() uses EX_TYPE_UACCESS instead of
> EX_TYPE_COPY，this change does not broken the MC safe copy for
> __copy_user_nocache(), but as a result, there's no place for EX_TYPE_COPY
> to use. Therefore, we remove the definition of EX_TYPE_COPY.

Please use passive voice in your commit message: no "we" or "I", etc,
and describe your changes in imperative mood.

Also, pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst for more details.

Also, see section "Changelog" in
Documentation/process/maintainer-tip.rst

> diff --git a/arch/x86/include/asm/extable_fixup_types.h b/arch/x86/include/asm/extable_fixup_types.h
> index fe6312045042..787916ec1e12 100644
> --- a/arch/x86/include/asm/extable_fixup_types.h
> +++ b/arch/x86/include/asm/extable_fixup_types.h
> @@ -36,18 +36,17 @@
>  #define	EX_TYPE_DEFAULT			 1
>  #define	EX_TYPE_FAULT			 2
>  #define	EX_TYPE_UACCESS			 3
> -#define	EX_TYPE_COPY			 4
> -#define	EX_TYPE_CLEAR_FS		 5
> -#define	EX_TYPE_FPU_RESTORE		 6
> -#define	EX_TYPE_BPF			 7
> -#define	EX_TYPE_WRMSR			 8
> -#define	EX_TYPE_RDMSR			 9
> -#define	EX_TYPE_WRMSR_SAFE		10 /* reg := -EIO */
> -#define	EX_TYPE_RDMSR_SAFE		11 /* reg := -EIO */
> -#define	EX_TYPE_WRMSR_IN_MCE		12
> -#define	EX_TYPE_RDMSR_IN_MCE		13
> -#define	EX_TYPE_DEFAULT_MCE_SAFE	14
> -#define	EX_TYPE_FAULT_MCE_SAFE		15
> +#define	EX_TYPE_CLEAR_FS		 4
> +#define	EX_TYPE_FPU_RESTORE		 5
> +#define	EX_TYPE_BPF			 6
> +#define	EX_TYPE_WRMSR			 7
> +#define	EX_TYPE_RDMSR			 8
> +#define	EX_TYPE_WRMSR_SAFE		 9 /* reg := -EIO */
> +#define	EX_TYPE_RDMSR_SAFE		10 /* reg := -EIO */
> +#define	EX_TYPE_WRMSR_IN_MCE		11
> +#define	EX_TYPE_RDMSR_IN_MCE		12
> +#define	EX_TYPE_DEFAULT_MCE_SAFE	13
> +#define	EX_TYPE_FAULT_MCE_SAFE		14

You don't need to renumber them - all you need to do is to comment it
out:

/* unused, was: #define EX_TYPE_COPY 		4 */

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette