linux-kernel - Re: [PATCH] Input: xpad - add Lenovo Legion Go controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zbl49VAMZx2qrz-p@google.com>
Date: Tue, 30 Jan 2024 14:32:21 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Brenton Simpson <appsforartists@...gle.com>
Cc: Vicki Pfau <vi@...rift.com>, Hans de Goede <hdegoede@...hat.com>,
	Cameron Gutman <aicommander@...il.com>,
	Erica Taylor <rickytaylor26@...il.com>,
	Ismael Ferreras Morezuelas <swyterzone@...il.com>,
	Jonathan Frederick <doublej472@...il.com>,
	Matthias Benkmann <matthias.benkmann@...il.com>,
	Matthias Berndt <matthias_berndt@....de>, nate@...om.org,
	Sam Lantinga <slouken@...sdl.org>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] Input: xpad - add Lenovo Legion Go controllers

Hi Brenton,

On Fri, Jan 19, 2024 at 12:22:45AM -0800, Brenton Simpson wrote:
> Thanks Vicki.  I didn't realize they were meant to be sorted.

Please try avoid top posting.

> 
> Would it be appropriate to add comments explaining the sorting?  The
> second stanza, in particular, is sorted by the IDs rather than
> lexicographically.  If someone sorted it naively, they'd end up with a
> bigger diff than expected.

Yes, we usually sort by VID/PID rather than the name of the device.

> 
> It looks like a few others have escaped sorting; for instance,
> "Microsoft X-Box One Elite 2 pad" appears in the wrong place.

Yep, sometimes we mess up.

> 
> If Dmitry wants to land this and then follow on with a sort + comment
> commit (or do that first and then rebase this on top), that would be
> great.  I can take a stab too if that's helpful.

I applied the patch (moving the entires to the right place). If someone
would send a patch fixing the Elite 2 entry and noting the sorting rules
I'd be happy to apply it.

Thanks.

-- 
Dmitry