linux-kernel - Re: [PATCH net v3] net: dsa: qca8k: fix illegal usage of GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <170658242380.31723.8345340437270157023.git-patchwork-notify@kernel.org>
Date: Tue, 30 Jan 2024 02:40:23 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Michal Vokáč <michal.vokac@...ft.com>@codeaurora.org
Cc: andrew@...n.ch, f.fainelli@...il.com, olteanv@...il.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 ansuelsmth@...il.com, rmk+kernel@...linux.org.uk, kabel@...nel.org,
 chunkeey@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 petr.benes@...ft.com
Subject: Re: [PATCH net v3] net: dsa: qca8k: fix illegal usage of GPIO

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 26 Jan 2024 11:49:35 +0100 you wrote:
> When working with GPIO, its direction must be set either when the GPIO is
> requested by gpiod_get*() or later on by one of the gpiod_direction_*()
> functions. Neither of this is done here which results in undefined
> behavior on some systems.
> 
> As the reset GPIO is used right after it is requested here, it makes sense
> to configure it as GPIOD_OUT_HIGH right away. With that, the following
> gpiod_set_value_cansleep(1) becomes redundant and can be safely
> removed.
> 
> [...]

Here is the summary with links:
  - [net,v3] net: dsa: qca8k: fix illegal usage of GPIO
    https://git.kernel.org/netdev/net/c/c44fc98f0a8f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html