linux-kernel - Re: [PATCH 30 1/7] Add JTAG core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024013039-tractor-subside-4535@gregkh>
Date: Tue, 30 Jan 2024 15:43:17 -0800
From: "'gregkh@...uxfoundation.org'" <gregkh@...uxfoundation.org>
To: "Corona, Ernesto" <ernesto.corona@...el.com>
Cc: "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
	"'oleksandrs@...lanox.com'" <oleksandrs@...lanox.com>,
	"'jiri@...dia.com'" <jiri@...dia.com>,
	"Castro, Omar Eduardo" <omar.eduardo.castro@...el.com>,
	"'omar.eduardo.castro@...ux.intel.com'" <omar.eduardo.castro@...ux.intel.com>,
	"'pombredanne@...b.com'" <pombredanne@...b.com>,
	"'arnd@...db.de'" <arnd@...db.de>,
	"'bbrezillon@...nel.org'" <bbrezillon@...nel.org>,
	"'rdunlap@...radead.org'" <rdunlap@...radead.org>,
	"'johan@...nel.org'" <johan@...nel.org>,
	"'axboe@...nel.dk'" <axboe@...nel.dk>,
	"'joel@....id.au'" <joel@....id.au>,
	"'palmer@...ive.com'" <palmer@...ive.com>,
	"'keescook@...omium.org'" <keescook@...omium.org>,
	"'vilhelm.gray@...il.com'" <vilhelm.gray@...il.com>,
	"'federico.vaga@...n.ch'" <federico.vaga@...n.ch>,
	"'Jonathan.Cameron@...wei.com'" <Jonathan.Cameron@...wei.com>,
	"Luck, Tony" <tony.luck@...el.com>,
	"'christian.gromm@...rochip.com'" <christian.gromm@...rochip.com>,
	"'linus.walleij@...aro.org'" <linus.walleij@...aro.org>,
	"'zzyiwei@...gle.com'" <zzyiwei@...gle.com>,
	"'rubini@...dd.com'" <rubini@...dd.com>,
	"'viresh.kumar@...aro.org'" <viresh.kumar@...aro.org>,
	"'mika.westerberg@...ux.intel.com'" <mika.westerberg@...ux.intel.com>,
	"Filary, Steven A" <steven.a.filary@...el.com>,
	"'vadimp@...lanox.com'" <vadimp@...lanox.com>,
	"'amithash@...com'" <amithash@...com>,
	"'patrickw3@...com'" <patrickw3@...com>,
	"Chen, Luke" <luke_chen@...eedtech.com>,
	"'billy_tsai@...eedtech.com'" <billy_tsai@...eedtech.com>,
	"'rgrs@...tonmail.com'" <rgrs@...tonmail.com>
Subject: Re: [PATCH 30 1/7] Add JTAG core driver

On Tue, Jan 30, 2024 at 11:26:19PM +0000, Corona, Ernesto wrote:
> +/**
> + * union pad_config - Padding Configuration:
> + *
> + * @type: transfer type
> + * @pre_pad_number: Number of prepadding bits bit[11:0]
> + * @post_pad_number: Number of prepadding bits bit[23:12]
> + * @pad_data : Bit value to be used by pre and post padding bit[24]
> + * @int_value: unsigned int packed padding configuration value bit[32:0]
> + *
> + * Structure provide pre and post padding configuration in a single __u32
> + */
> +union pad_config {

Bad name for a global structure, don't you think?

> +	struct {
> +		__u32 pre_pad_number	: 12;
> +		__u32 post_pad_number	: 12;
> +		__u32 pad_data		: 1;
> +		__u32 rsvd		: 7;
> +	};

This obviously does not work, please don't do that.

thanks,

greg k-h