linux-kernel - Re: [PATCH] mm/slub: remove parameter 'flags' in create_kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <388197b3-6193-96ce-8e8d-261c8481eff3@google.com>
Date: Mon, 29 Jan 2024 19:11:23 -0800 (PST)
From: David Rientjes <rientjes@...gle.com>
To: Zheng Yejian <zhengyejian1@...wei.com>
cc: cl@...ux.com, penberg@...nel.org, iamjoonsoo.kim@....com, 
    akpm@...ux-foundation.org, vbabka@...e.cz, roman.gushchin@...ux.dev, 
    42.hyeyoo@...il.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/slub: remove parameter 'flags' in
 create_kmalloc_caches()

On Tue, 30 Jan 2024, Zheng Yejian wrote:

> After commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"),
> parameter 'flags' is only passed as 0 in create_kmalloc_caches(), and
> then it is only passed to new_kmalloc_cache().
> 
> So we can change parameter 'flags' to be a local variable with
> initial value 0 in new_kmalloc_cache() and remove parameter 'flags'
> in create_kmalloc_caches(). Also make new_kmalloc_cache() static
> due to it is only used in mm/slab_common.c.
> 
> Signed-off-by: Zheng Yejian <zhengyejian1@...wei.com>

Acked-by: David Rientjes <rientjes@...gle.com>