linux-kernel - Re: [PATCH net-next v2 2/2] net: dsa: Add KSZ8567 switch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b6575afdba8c3207752ebfa1cddc490f7bee5a4.camel@microchip.com>
Date: Tue, 30 Jan 2024 04:03:32 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <dev@...henker.ch>, <netdev@...r.kernel.org>
CC: <andrew@...n.ch>, <olteanv@...il.com>,
	<krzysztof.kozlowski+dt@...aro.org>, <Woojung.Huh@...rochip.com>,
	<davem@...emloft.net>, <philippe.schenker@...ulsing.ch>,
	<linux-kernel@...r.kernel.org>, <edumazet@...gle.com>, <conor+dt@...nel.org>,
	<marex@...x.de>, <devicetree@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>, <stefan.portmann@...ulsing.ch>,
	<kuba@...nel.org>, <robh+dt@...nel.org>, <pabeni@...hat.com>,
	<f.fainelli@...il.com>
Subject: Re: [PATCH net-next v2 2/2] net: dsa: Add KSZ8567 switch support

Hi Philippe,

On Thu, 2024-01-25 at 09:05 +0100, Philippe Schenker wrote:
> 
> diff --git a/include/linux/platform_data/microchip-ksz.h
> b/include/linux/platform_data/microchip-ksz.h
> index f177416635a2..c4466e56d9d7 100644
> --- a/include/linux/platform_data/microchip-ksz.h
> +++ b/include/linux/platform_data/microchip-ksz.h
> @@ -24,6 +24,7 @@
> 
>  enum ksz_chip_id {
>         KSZ8563_CHIP_ID = 0x8563,
> +       KSZ8567_CHIP_ID = 0x00856700,
>         KSZ8795_CHIP_ID = 0x8795,
>         KSZ8794_CHIP_ID = 0x8794,
>         KSZ8765_CHIP_ID = 0x8765,

nitpick: can you move KSZ8567 adjacent to KSZ9567. Since first KSZ8x
chips have chipid of 16 bits length. Others have 32 bits length.

otherwise it looks good to me. 

Acked-by: Arun Ramadoss <arun.ramadoss@...rochip.com> 
> --
> 2.34.1
>