linux-kernel - Re: [net-next v5 1/2] net: phy: phy_device: Prevent nullptr exceptions on ISR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 Jan 2024 07:54:04 +0100 (CET)
From: Andre Werner <andre.werner@...tec-electronic.com>
To: Andrew Lunn <andrew@...n.ch>
cc: Andre Werner <andre.werner@...tec-electronic.com>, hkallweit1@...il.com, 
    davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
    pabeni@...hat.com, linux@...linux.org.uk, netdev@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [net-next v5 1/2] net: phy: phy_device: Prevent nullptr exceptions
 on ISR

Thanks Andrew,

I will keep this in mind. Sorry!

Andre


On Mon, 29 Jan 2024, Andrew Lunn wrote:

> On Mon, Jan 29, 2024 at 02:55:04PM +0100, Andre Werner wrote:
>> If phydev->irq is set unconditionally, check
>> for valid interrupt handler or fall back to polling mode to prevent
>> nullptr exceptions in interrupt service routine.
>>
>> Signed-off-by: Andre Werner <andre.werner@...tec-electronic.com>
>> Reviewed-by: Andrew Lunn <andrew@...n.ch>
>
> Nitpick:
>
> Your Signed-off-by: should go last.
>
> Its not enough to need a respin, but please keep this in mind for
> future patches.
>
>       Andrew
>