linux-kernel - Re: [PATCH v2] mmc: renesas_sdhi: Fix change point of data handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zbilu9u9Z3MeeOb9@ninjato>
Date: Tue, 30 Jan 2024 08:31:07 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: claudiu beznea <claudiu.beznea@...on.dev>, ulf.hansson@...aro.org,
	takeshi.saito.xv@...esas.com, masaharu.hayakawa.ry@...esas.com,
	yoshihiro.shimoda.uh@...esas.com, linux-mmc@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v2] mmc: renesas_sdhi: Fix change point of data handling


> But isn't it equal to the current code then? (Except for one thing: the
> smpcmp bit is only set when there is no cmd error. I need to double
> check but I think I like that.)

I double checked, I really like it. I'd just invert the logic. Pseudo
code:

if (!cmd_error)
	if (SMPCMP == 0) set_bit
else
	mmc_abort_tuning()



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)