linux-kernel - RE: [PATCH iwl v2] i40e: print correct hw max rss count in kernel ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 Jan 2024 08:33:43 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>
CC: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Suresh Kumar
	<suresh2514@...il.com>
Subject: RE: [PATCH iwl v2] i40e: print correct hw max rss count in kernel
 ring buffer

> -----Original Message-----
> From: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Sent: Tuesday, January 30, 2024 9:26 AM
> To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>
> Subject: Fwd: [PATCH iwl v2] i40e: print correct hw max rss count
> in kernel ring buffer
> 
> FWD to Alex
> 
> 
> -------- Forwarded Message --------
> Subject: [PATCH iwl v2] i40e: print correct hw max rss count in
> kernel ring buffer
> Date: Sat, 20 Jan 2024 12:58:06 +0530
> From: Suresh Kumar <suresh2514@...il.com>
> To: jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
> davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
> pabeni@...hat.com, intel-wired-lan@...ts.osuosl.org,
> netdev@...r.kernel.org, linux-kernel@...r.kernel.org
> CC: Suresh Kumar <suresh2514@...il.com>
> 
> pf->rss_size_max is hardcoded and always prints max rss count as
> 64.
> 
> Eg:
>    kernel: i40e 0000:af:00.1: User requested queue count/HW max RSS
> count:  104/64
> 
> whereas  ethtool reports the correct value from "vsi-
> >num_queue_pairs"
> 
> Channel parameters for eno33:
> Pre-set maximums:
> RX:     n/a
> TX:     n/a
> Other:      1
> Combined:   104
> Current hardware settings:
> RX:     n/a
> TX:     n/a
> Other:      1
> Combined:   104  <-------
> 
> and is misleading.
> 
> Change it to vsi->num_queue_pairs

Please reject this patch, it breaks driver logging.
The massage clearly states that it dumps max rss queues number that f/w supports.

Thank you
 
> Signed-off-by: Suresh Kumar <suresh2514@...il.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index d5519af34657..f5c1ec190f7e 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -12524,7 +12524,7 @@ int i40e_reconfig_rss_queues(struct i40e_pf
> *pf, int queue_count)
>   		i40e_pf_config_rss(pf);
>   	}
>   	dev_info(&pf->pdev->dev, "User requested queue count/HW max
> RSS
> count:  %d/%d\n",
> -		 vsi->req_queue_pairs, pf->rss_size_max);
> +		 vsi->req_queue_pairs, vsi->num_queue_pairs);
>   	return pf->alloc_rss_size;
>   }
>   -- 2.43.0
>