linux-kernel - Re: [PATCH v9 01/27] x86/fpu/xstate: Always preserve non-user xfeatures/flags in __state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77ccb09bd946fd27f17f530ed8fb4484afa46a00.camel@intel.com>
Date: Tue, 30 Jan 2024 01:29:33 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "Yang, Weijiang" <weijiang.yang@...el.com>, "Hansen, Dave"
	<dave.hansen@...el.com>, "seanjc@...gle.com" <seanjc@...gle.com>,
	"x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "yuan.yao@...ux.intel.com"
	<yuan.yao@...ux.intel.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>
CC: "john.allen@....com" <john.allen@....com>, "peterz@...radead.org"
	<peterz@...radead.org>, "Gao, Chao" <chao.gao@...el.com>,
	"mlevitsk@...hat.com" <mlevitsk@...hat.com>
Subject: Re: [PATCH v9 01/27] x86/fpu/xstate: Always preserve non-user
 xfeatures/flags in __state_perm

On Tue, 2024-01-23 at 18:41 -0800, Yang Weijiang wrote:
> +       /*
> +        * Calculate the resulting kernel state size.  Note,
> @permitted also
> +        * contains supervisor xfeatures even though supervisor are
> always
> +        * permitted for kernel and guest FPUs, and never permitted
> for user
> +        * FPUs.
> +        */

I still find this verbiage confusing, but maybe it's just me.

Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>