linux-kernel - Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c073b12-c1b7-44fd-8f46-d901a4cd403c@blackwall.org>
Date: Tue, 30 Jan 2024 11:29:11 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Kunwu Chan <chentao@...inos.cn>, roopa@...dia.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: bridge@...ts.linux.dev, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of
 kmem_cache_create

On 30/01/2024 11:25, Kunwu Chan wrote:
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
> 
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> ---
>  net/bridge/br_fdb.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index c622de5eccd0..c77591e63841 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -35,10 +35,7 @@ static struct kmem_cache *br_fdb_cache __read_mostly;
>  
>  int __init br_fdb_init(void)
>  {
> -	br_fdb_cache = kmem_cache_create("bridge_fdb_cache",
> -					 sizeof(struct net_bridge_fdb_entry),
> -					 0,
> -					 SLAB_HWCACHE_ALIGN, NULL);
> +	br_fdb_cache = KMEM_CACHE(net_bridge_fdb_entry, SLAB_HWCACHE_ALIGN);
>  	if (!br_fdb_cache)
>  		return -ENOMEM;
>  

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>