linux-kernel - Re: [PATCH net-next v6 1/2] net: introduce abstraction for network memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 Jan 2024 10:59:53 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Mina Almasry <almasrymina@...gle.com>, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>, Jason Gunthorpe
 <jgg@...dia.com>, Christian König
 <christian.koenig@....com>, Shakeel Butt <shakeelb@...gle.com>, Yunsheng
 Lin <linyunsheng@...wei.com>, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next v6 1/2] net: introduce abstraction for network
 memory

On Tue, 2024-01-23 at 14:17 -0800, Mina Almasry wrote:
> diff --git a/include/net/netmem.h b/include/net/netmem.h
> new file mode 100644
> index 000000000000..9f327d964782
> --- /dev/null
> +++ b/include/net/netmem.h
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0
> + *
> + *	Network memory
> + *
> + *	Author:	Mina Almasry <almasrymina@...gle.com>
> + */
> +
> +#ifndef _NET_NETMEM_H
> +#define _NET_NETMEM_H
> +
> +/**
> + * netmem_ref - a nonexistent type marking a reference to generic network

Minor nit: here you need to prepend 'struct' to avoid a kdoc warning:

include/net/netmem.h:20: warning: cannot understand function prototype: 'typedef unsigned long __bitwise netmem_ref; '

Should be:

* struct netmem_ref - a nonexistent type marking a reference to generic network

Cheers,

Paolo