linux-kernel - Re: [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 Jan 2024 10:34:22 +0000
From: Mark Rutland <mark.rutland@....com>
To: Kemeng Shi <shikemeng@...weicloud.com>
Cc: catalin.marinas@....com, will@...nel.org, revest@...omium.org,
	rostedt@...dmis.org, arnd@...db.de, pengdonglin@...gfor.com.cn,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: make member of struct pt_regs and it's offset
 macro in the same order

On Wed, Jan 31, 2024 at 01:55:04AM +0800, Kemeng Shi wrote:
> In struct pt_regs, member pstate is after member pc. Move offset macro
> of pstate after offset macro of pc to improve readability a little.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>

I think this makes sense as a trivial cleanup, so FWIW:

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.

> ---
>  arch/arm64/kernel/asm-offsets.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
> index 5ff1942b04fc..865ba901c233 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -75,8 +75,8 @@ int main(void)
>    DEFINE(S_FP,			offsetof(struct pt_regs, regs[29]));
>    DEFINE(S_LR,			offsetof(struct pt_regs, regs[30]));
>    DEFINE(S_SP,			offsetof(struct pt_regs, sp));
> -  DEFINE(S_PSTATE,		offsetof(struct pt_regs, pstate));
>    DEFINE(S_PC,			offsetof(struct pt_regs, pc));
> +  DEFINE(S_PSTATE,		offsetof(struct pt_regs, pstate));
>    DEFINE(S_SYSCALLNO,		offsetof(struct pt_regs, syscallno));
>    DEFINE(S_SDEI_TTBR1,		offsetof(struct pt_regs, sdei_ttbr1));
>    DEFINE(S_PMR_SAVE,		offsetof(struct pt_regs, pmr_save));
> -- 
> 2.30.0
>