linux-kernel - Re: [PATCH] soc/tegra: fix build failure on Tegra241

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0c534cc7a58034aa15f937a26525887bcd323be.camel@nvidia.com>
Date: Tue, 30 Jan 2024 11:45:15 +0000
From: Kartik Rajput <kkartik@...dia.com>
To: Jonathan Hunter <jonathanh@...dia.com>, "arnd@...nel.org"
	<arnd@...nel.org>, "thierry.reding@...il.com" <thierry.reding@...il.com>
CC: "robh@...nel.org" <robh@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "arnd@...db.de" <arnd@...db.de>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] soc/tegra: fix build failure  on Tegra241

On Wed, 2024-01-03 at 11:26 +0100, Arnd Bergmann wrote:
> External email: Use caution opening links or attachments
> 
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> If all the other SoCs are disabled, the driver fails to build:
> 
> drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error:
> 'tegra30_fuse_read' undeclared here (not in a function); did you mean
> 'tegra_fuse_readl'?
>   684 |         .read = tegra30_fuse_read,
>       |                 ^~~~~~~~~~~~~~~~~
>       |                 tegra_fuse_readl
> drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error:
> 'tegra30_fuse_init' undeclared here (not in a function); did you mean
> 'tegra_fuse_info'?
>   694 |         .init = tegra30_fuse_init,
>       |                 ^~~~~~~~~~~~~~~~~
> 
> Fix the list of SoCs using this function to include the newly added
> one.
> 
> Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c
> b/drivers/soc/tegra/fuse/fuse-tegra30.c
> index 2070d36c510d..eb14e5ff5a0a 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra30.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
> @@ -38,7 +38,8 @@
>      defined(CONFIG_ARCH_TEGRA_210_SOC) || \
>      defined(CONFIG_ARCH_TEGRA_186_SOC) || \
>      defined(CONFIG_ARCH_TEGRA_194_SOC) || \
> -    defined(CONFIG_ARCH_TEGRA_234_SOC)
> +    defined(CONFIG_ARCH_TEGRA_234_SOC) || \
> +    defined(CONFIG_ARCH_TEGRA_241_SOC)
>  static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned
> int offset)
>  {
>         if (WARN_ON(!fuse->base))
> --
> 2.39.2
> 

Thanks Arnd!

Reviewed-by: Kartik <kkartik@...dia.com>