linux-kernel - Re: [PATCH v2 1/3] perf tsc: Add missing newlines to debug statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 31 Jan 2024 05:51:36 -0800
From: Ian Rogers <irogers@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, 
	Kan Liang <kan.liang@...ux.intel.com>, James Clark <james.clark@....com>, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
	tchen168@....edu, Michael Petlan <mpetlan@...hat.com>
Subject: Re: [PATCH v2 1/3] perf tsc: Add missing newlines to debug statements

On Wed, Jan 31, 2024 at 5:49 AM Ian Rogers <irogers@...gle.com> wrote:
>
> It is assumed that debug statements always print a newline, fix two
> missing ones.
>
> Signed-off-by: Ian Rogers <irogers@...gle.com>

Sorry forgot to add:
Reviewed-by: James Clark <james.clark@....com>
To this one.

Thanks,
Ian

> ---
> This patch was inspired by bad debug output in:
> https://lore.kernel.org/linux-perf-users/CAGjhMsg_bVKJ_zfsLUR32+oZwGDr3OiBHV_BJ3QtFjyKAs7Sgg@mail.gmail.com/
> ---
>  tools/perf/arch/x86/util/tsc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/arch/x86/util/tsc.c b/tools/perf/arch/x86/util/tsc.c
> index 9b99f48b923c..e2d6cfe21057 100644
> --- a/tools/perf/arch/x86/util/tsc.c
> +++ b/tools/perf/arch/x86/util/tsc.c
> @@ -33,7 +33,7 @@ static double cpuinfo_tsc_freq(void)
>
>         cpuinfo = fopen("/proc/cpuinfo", "r");
>         if (!cpuinfo) {
> -               pr_err("Failed to read /proc/cpuinfo for TSC frequency");
> +               pr_err("Failed to read /proc/cpuinfo for TSC frequency\n");
>                 return NAN;
>         }
>         while (getline(&line, &len, cpuinfo) > 0) {
> @@ -48,7 +48,7 @@ static double cpuinfo_tsc_freq(void)
>         }
>  out:
>         if (fpclassify(result) == FP_ZERO)
> -               pr_err("Failed to find TSC frequency in /proc/cpuinfo");
> +               pr_err("Failed to find TSC frequency in /proc/cpuinfo\n");
>
>         free(line);
>         fclose(cpuinfo);
> --
> 2.43.0.429.g432eaa2c6b-goog
>