linux-kernel - Re: [PATCH v9] bus: mhi: host: Add tracing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13703200-af1a-4776-98b2-b9a7261de2e6@quicinc.com>
Date: Wed, 31 Jan 2024 07:22:54 +0530
From: Krishna Chaitanya Chundru <quic_krichai@...cinc.com>
To: Manivannan Sadhasivam <mani@...nel.org>,
        Steven Rostedt
	<rostedt@...dmis.org>
CC: Masami Hiramatsu <mhiramat@...nel.org>, <linux-kernel@...r.kernel.org>,
        <mhi@...ts.linux.dev>, <linux-arm-msm@...r.kernel.org>,
        <linux-trace-kernel@...r.kernel.org>, <quic_vbadigan@...cinc.com>,
        <quic_ramkri@...cinc.com>, <quic_nitegupt@...cinc.com>,
        <quic_skananth@...cinc.com>, <quic_parass@...cinc.com>
Subject: Re: [PATCH v9] bus: mhi: host: Add tracing support



On 1/30/2024 11:56 PM, Manivannan Sadhasivam wrote:
> On Tue, Jan 30, 2024 at 09:22:52AM -0500, Steven Rostedt wrote:
>> On Tue, 30 Jan 2024 13:41:52 +0530
>> Manivannan Sadhasivam <mani@...nel.org> wrote:
>>
>>> So same trace will get printed for both mhi_channel_command_start() and
>>> mhi_channel_command_end()?
>>
>> The trace output will also include the tracepoint name. That is, it will
>> have the same content but will be preceded with:
>>
>>    mhi_channel_command_start: ...
>>    mhi_channel_command_end: ...
>>
> 
> Yes, but the message will be the same:
> 
> mhi_channel_command_start: chan%d: Updating state to:
> mhi_channel_command_end: chan%d: Updating state to:
> 
> Either only one of the trace should be present or the second one should print,
> "mhi_channel_command_end: chan%d: Updated state to:"
> 
> - Mani
>
I will try to pass a string to updated for mhi_channel_command_end &
updating for mhi_channel_command_start in my next patch.

- Krishna Chaitanya.