[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240131160136.GA587669@bhelgaas>
Date: Wed, 31 Jan 2024 10:01:36 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Jingoo Han <jingoohan1@...il.com>,
Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, imx@...ts.linux.dev,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: PCI: dwc: Add 'msg" register region
Super nit: use matching quotes in subject.
On Tue, Jan 30, 2024 at 07:45:30PM -0500, Frank Li wrote:
> Add a outbound iATU-capable memory-region which will be use to send PCI
> message (such as pme-turn-off) to peripheral. So all platforms can use
> common method to send out pme-turn-off message by using one outbound iATU.
s/Add a outbound/Add an outbound/
s/will be use/will be used/ (also below)
s/PCI/PCIe/ (also below)
s/pme-turn-off/PME_Turn_Off/ to make it more searchable in spec (also below)
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> index 022055edbf9e6..e27d81b6a131c 100644
> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> @@ -101,6 +101,10 @@ properties:
> Outbound iATU-capable memory-region which will be used to access
> the peripheral PCIe devices configuration space.
> const: config
> + - description:
> + Outbound iATU-capable memory-region which will be use to send
> + PCI message (such as pme-turn-off) to peripheral.
> + const: msg
> - description:
> Vendor-specific CSR names. Consider using the generic names above
> for new bindings.
>
> --
> 2.34.1
>
Powered by blists - more mailing lists