linux-kernel - Re: [PATCH v3] dt-bindings: iio: afe: voltage-divider: Add io-channel-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240131163516.000043df@Huawei.com>
Date: Wed, 31 Jan 2024 16:35:16 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC: Naresh Solanki <naresh.solanki@...ements.com>, Peter Rosin
	<peda@...ntia.se>, Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen
	<lars@...afoo.de>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
	<mazziesaccount@...il.com>, <linux-iio@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] dt-bindings: iio: afe: voltage-divider: Add
 io-channel-cells

On Wed, 31 Jan 2024 09:29:59 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 30/01/2024 12:56, Naresh Solanki wrote:
> > voltage-divider is always an iio consumer at the same time it is
> > optionally an iio provider.
> > Hence add #io-channel-cells
> > Also update example.
> >   
> 
> Fix
> wrapping
> and
> proper
> sentences. Each sentence finishes with full stop.
> 
> ...
> >    output-ohms:
> >      description:
> >        Resistance Rout over which the output voltage is measured. See full-ohms.
> > @@ -75,12 +82,17 @@ examples:
> >              spi-max-frequency = <1000000>;
> >          };
> >      };
> > -    sysv {
> > +    p12v_vd: sysv {  
> 
> No, drop label.
> 
> >          compatible = "voltage-divider";
> >          io-channels = <&maxadc 1>;
> > +        #io-channel-cells = <1>;
> >  
> >          /* Scale the system voltage by 22/222 to fit the ADC range. */
> >          output-ohms = <22>;
> >          full-ohms = <222>; /* 200 + 22 */
> >      };
> > +    iio-hwmon {
> > +        compatible = "iio-hwmon";
> > +        io-channels = <&p12v_vd 0>;  
> 
> The same question as for v2. Drop unrelated example.

Conor requested an example of the device acting as a consumer and a provider.
Might have meant in the patch description?

Conor?
> 
> Also, remember about rule of posting only one version per day, so people
> actually have some chance to look at your patch.
> 
> Best regards,
> Krzysztof
> 
>