linux-kernel - [PATCH RFC v4 08/15] ACPI: Warn when the present bit changes but the feature is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1rVDmz-0027Yz-GE@rmk-PC.armlinux.org.uk>
Date: Wed, 31 Jan 2024 16:50:17 +0000
From: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
To: linux-pm@...r.kernel.org,
	 loongarch@...ts.linux.dev,
	 linux-acpi@...r.kernel.org,
	 linux-arch@...r.kernel.org,
	 linux-kernel@...r.kernel.org,
	 linux-arm-kernel@...ts.infradead.org,
	 linux-riscv@...ts.infradead.org,
	 kvmarm@...ts.linux.dev,
	 x86@...nel.org,
	 acpica-devel@...ts.linuxfoundation.org,
	 linux-csky@...r.kernel.org,
	 linux-doc@...r.kernel.org,
	 linux-ia64@...r.kernel.org,
	 linux-parisc@...r.kernel.org
Cc: Salil Mehta <salil.mehta@...wei.com>,
	 Jean-Philippe Brucker <jean-philippe@...aro.org>,
	 jianyong.wu@....com,
	 justin.he@....com,
	 James Morse <james.morse@....com>,
	 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	 "Rafael J. Wysocki" <rafael@...nel.org>
Subject: [PATCH RFC v4 08/15] ACPI: Warn when the present bit changes but the
 feature is not enabled

From: James Morse <james.morse@....com>

ACPI firmware can trigger the events to add and remove CPUs, but the
OS may not support this.

Print an error message when this happens.

This gives early warning on arm64 systems that don't support
CONFIG_ACPI_HOTPLUG_PRESENT_CPU, as making CPUs not present has
side effects for other parts of the system.

Signed-off-by: James Morse <james.morse@....com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Reviewed-by: Gavin Shan <gshan@...hat.com>
Tested-by: Miguel Luis <miguel.luis@...cle.com>
Tested-by: Vishnu Pajjuri <vishnu@...amperecomputing.com>
Tested-by: Jianyong Wu <jianyong.wu@....com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
---
Changes since RFC v2:
 * Update commit message with suggestion from Gavin Shan
---
 drivers/acpi/acpi_processor.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index 77d47e6c2474..d1d33e74216c 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -189,8 +189,10 @@ static int acpi_processor_make_present(struct acpi_processor *pr)
 	acpi_status status;
 	int ret;
 
-	if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_CPU))
+	if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_CPU)) {
+		pr_err_once("Changing CPU present bit is not supported\n");
 		return -ENODEV;
+	}
 
 	if (invalid_phys_cpuid(pr->phys_id))
 		return -ENODEV;
@@ -462,8 +464,10 @@ static void acpi_processor_make_not_present(struct acpi_device *device)
 {
 	struct acpi_processor *pr;
 
-	if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_CPU))
+	if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_CPU)) {
+		pr_err_once("Changing CPU present bit is not supported");
 		return;
+	}
 
 	pr = acpi_driver_data(device);
 	if (pr->id >= nr_cpu_ids)
-- 
2.30.2