linux-kernel - Re: [PATCH v2] usb: gadget: ncm: Avoid dropping datagrams of properly parsed NTBs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 31 Jan 2024 23:40:01 +0530
From: Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
To: Maciej Żenczykowski <maze@...gle.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hardik Gajjar
	<hgajjar@...adit-jv.com>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_ppratap@...cinc.com>,
        <quic_wcheng@...cinc.com>, <quic_jackp@...cinc.com>
Subject: Re: [PATCH v2] usb: gadget: ncm: Avoid dropping datagrams of properly
 parsed NTBs



On 1/31/2024 10:48 PM, Maciej Żenczykowski wrote:

>>
>> Also since this is a fix, it should probably have a Fixes tag
>> (possibly on some original sha1 that added the driver, since I think
>> it's always been broken) or at least a commit title that more clearly
>> flags it as a 'fix' or cc stable...
>>
>> (something like 'usb: gadget: ncm: fix rare win11 packet discard')
>>
>> We definitely want this to hit LTS...
> 
> One more thing: the 'goto done' and 'done' label are not needed -
> that's already the natural code flow...
> So the 'goto' could just be replaced with a comment or perhaps with
> --to_process.

ACK. I thought getting out of the function was better than doing a NOP 
calculation. Either ways is fine by me. Will make this change in v3.

Regards,
Krishna,