[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZbqwOKSsGWB9QREM@google.com>
Date: Wed, 31 Jan 2024 12:40:24 -0800
From: William McVicker <willmcvicker@...gle.com>
To: André Draszik <andre.draszik@...aro.org>
Cc: peter.griffin@...aro.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
linux-kernel@...r.kernel.org, kernel-team@...roid.com,
tudor.ambarus@...aro.org, semen.protsenko@...aro.org,
alim.akhtar@...sung.com, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: exynos: gs101: add stable i2c aliases for
gs101-oriole
Hi Andre,
On 01/30/2024, André Draszik wrote:
> Now that we have more than i2c interface, add aliases to ensure
> deterministic bus number assignment.
>
> So as to keep compatibility with existing Pixel userspace builds, use
> the same bus numbers for hsi2c_8 and hsi2c_12 as the downstream
> drivers with the intention to eventually add all the earlier busses as
> well.
>
> Suggested-by: Will McVicker <willmcvicker@...gle.com>
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
Tested-by: Will McVicker <willmcvicker@...gle.com>
>
> ---
> Note, this patch should only be applied after series
> "[PATCH v3 0/7] gs101 oriole: peripheral block 1 (peric1) and i2c12 support"
> https://lore.kernel.org/all/20240129174703.1175426-1-andre.draszik@linaro.org/
> ---
> arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index 6ccade2c8cb4..23314ed78c96 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -18,6 +18,8 @@ / {
> compatible = "google,gs101-oriole", "google,gs101";
>
> aliases {
> + i2c7 = &hsi2c_8;
> + i2c8 = &hsi2c_12;
> serial0 = &serial_0;
> };
>
> --
> 2.43.0.429.g432eaa2c6b-goog
>
I verified this works on my device:
# ls -l /sys/bus/i2c/devices/
total 0
<snip> 7-0050 -> ../../../devices/platform/soc@...09700c0.usi/10970000.i2c/i2c-7/7-0050
<snip> i2c-7 -> ../../../devices/platform/soc@...09700c0.usi/10970000.i2c/i2c-7
<snip> i2c-8 -> ../../../devices/platform/soc@...0d500c0.usi/10d50000.i2c/i2c-8
Thanks,
Will
Powered by blists - more mailing lists