linux-kernel - Re: [PATCH RESEND] nfc: hci: Save a few bytes of memory when registering a 'nfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 31 Jan 2024 15:08:03 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH RESEND] nfc: hci: Save a few bytes of memory when
 registering a 'nfc_llc' engine

On Sat, 27 Jan 2024 10:58:29 +0100 Christophe JAILLET wrote:
> nfc_llc_register() calls pass a string literal as the 'name' parameter.
> 
> So kstrdup_const() can be used instead of kfree() to avoid a memory
> allocation in such cases.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

There is a kfree() call in nfc_llc_exit() that looks suspiciously
like it may also free the name.