linux-kernel - Re: [PATCH 1/1] block: print warning when invalid domain set to ioprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 1 Feb 2024 08:59:36 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Zhaoyang Huang <huangzhaoyang@...il.com>,
 Niklas Cassel <Niklas.Cassel@....com>
Cc: "zhaoyang.huang" <zhaoyang.huang@...soc.com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>,
 Hannes Reinecke <hare@...e.de>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "steve.kang@...soc.com" <steve.kang@...soc.com>,
 "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
 Bart Van Assche <bvanassche@....org>
Subject: Re: [PATCH 1/1] block: print warning when invalid domain set to
 ioprio

On 2/1/24 08:34, Zhaoyang Huang wrote:
> On Wed, Jan 31, 2024 at 9:07 PM Niklas Cassel <Niklas.Cassel@....com> wrote:
>> This sound like either a bug in the FS or by some of your local changes
>> that you did for your other patch (ioprio based on activity).
> Yes. That's why I would like to suggest adding some information here
> to help developers find the clue quickly.

The backtrace was not clear enough ?

When a request reaches mq-deadline, the request priority is supposed to be
correct already. Your changes had a bug and broke that assumption. Please fix
that instead of adding error messages for errors that should never happen in the
first place.

-- 
Damien Le Moal
Western Digital Research